src/hydrogen-uint32-analysis.cc - Issue 1077113002: Treat HArgumentsObject as a safe use during Uint32 analysis phase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-uint32-analysis.cc

Issue 1077113002: Treat HArgumentsObject as a safe use during Uint32 analysis phase. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove assertOptimized Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-uint32-analysis.cc

diff --git a/src/hydrogen-uint32-analysis.cc b/src/hydrogen-uint32-analysis.cc

index 585a7066f60f23242a458e95504814e556f1a329..85075848630d348e94a1958494afb6ede7fa33ca 100644

--- a/src/hydrogen-uint32-analysis.cc

+++ b/src/hydrogen-uint32-analysis.cc

@@ -36,7 +36,7 @@ bool HUint32AnalysisPhase::IsSafeUint32Use(HValue* val, HValue* use) {

// Operations that operate on bits are safe.

if (use->IsBitwise() || use->IsShl() || use->IsSar() || use->IsShr()) {

return true;

- } else if (use->IsSimulate()) {

+ } else if (use->IsSimulate() || use->IsArgumentsObject()) {

// Deoptimization has special support for uint32.

return true;

} else if (use->IsChange()) {

« no previous file with comments | « src/deoptimizer.cc ('k') | test/mjsunit/compiler/uint32.js » ('j') | no next file with comments »