Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1076813002: Settings link in smartlock infobars redirect user to Password manager preferences page. (Closed)

Created:
5 years, 8 months ago by melandory
Modified:
5 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings link in smartlock infobars redirect user to Password manager preferences page. Redirect user to Password manager preferences page, where auto sign in checkbox is located. BUG=454815 R=bauerb@chromium.org Committed: https://crrev.com/2e188ab26e23a32cd50353626c9251801ac3e762 Cr-Commit-Position: refs/heads/master@{#324428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
melandory
Hi, please review this CL. Thanks in advance.
5 years, 8 months ago (2015-04-09 13:25:29 UTC) #1
Bernhard Bauer
lgtm
5 years, 8 months ago (2015-04-09 13:36:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076813002/1
5 years, 8 months ago (2015-04-09 13:40:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 13:49:00 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 13:49:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e188ab26e23a32cd50353626c9251801ac3e762
Cr-Commit-Position: refs/heads/master@{#324428}

Powered by Google App Engine
This is Rietveld 408576698