Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2118)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java

Issue 1076813002: Settings link in smartlock infobars redirect user to Password manager preferences page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java
index b41d00581335246f7eb6a36d60575804bb8b8628..8eed87207c7f7244678cabc3c33bbc93825dcc7a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java
@@ -14,6 +14,7 @@ import android.widget.PopupMenu.OnMenuItemClickListener;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.preferences.PreferencesLauncher;
+import org.chromium.chrome.browser.preferences.password.ManageSavedPasswordsPreferences;
import org.chromium.chrome.browser.widget.ButtonCompat;
/**
@@ -56,9 +57,8 @@ public class OverflowSelector {
private static boolean processMenuItem(MenuItem item, Context context) {
if (item.getItemId() == R.id.settings) {
- // TODO(melandory) When Smart Lock setting will be implemented for Chrome on Android
- // this code should open settings fragment with Smart Lock parameters.
- PreferencesLauncher.launchSettingsPage(context, null);
+ PreferencesLauncher.launchSettingsPage(
+ context, ManageSavedPasswordsPreferences.class.getName());
return true;
}
// TODO(melandory): Learn more should open link to help center
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698