Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1076723002: V8 Buildbot: Split x87 into builder/tester. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org, Weiliang, chunyang.dai
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

V8 Buildbot: Split x87 into builder/tester. The builder part needs to move to a Trusty bot. TBR=stip@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294737

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -22 lines) Patch
M masters/master.client.v8/mail_notifier_cfg.py View 2 chunks +2 lines, -1 line 0 comments Download
M masters/master.client.v8/master.cfg View 3 chunks +9 lines, -1 line 0 comments Download
M masters/master.client.v8/slaves.cfg View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/gatekeeper.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/api.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/builders.py View 1 2 chunks +17 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___x87___nosnap___debug.json View 1 2 chunks +28 lines, -11 lines 0 comments Download
A + scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___x87___nosnap___debug_builder.json View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Michael Achenbach
PTAL
5 years, 8 months ago (2015-04-09 09:13:37 UTC) #2
kjellander_chromium
https://codereview.chromium.org/1076723002/diff/1/scripts/slave/recipe_modules/v8/builders.py File scripts/slave/recipe_modules/v8/builders.py (right): https://codereview.chromium.org/1076723002/diff/1/scripts/slave/recipe_modules/v8/builders.py#newcode1051 scripts/slave/recipe_modules/v8/builders.py:1051: 'parent_buildername': 'V8 Linux - debug builder', This should be ...
5 years, 8 months ago (2015-04-09 09:17:14 UTC) #3
Michael Achenbach
Done https://codereview.chromium.org/1076723002/diff/1/scripts/slave/recipe_modules/v8/builders.py File scripts/slave/recipe_modules/v8/builders.py (right): https://codereview.chromium.org/1076723002/diff/1/scripts/slave/recipe_modules/v8/builders.py#newcode1051 scripts/slave/recipe_modules/v8/builders.py:1051: 'parent_buildername': 'V8 Linux - debug builder', On 2015/04/09 ...
5 years, 8 months ago (2015-04-09 09:19:30 UTC) #4
kjellander_chromium
lgtm
5 years, 8 months ago (2015-04-09 09:23:26 UTC) #5
tandrii(chromium)
lgtm
5 years, 8 months ago (2015-04-09 11:17:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076723002/20001
5 years, 8 months ago (2015-04-09 12:11:08 UTC) #8
commit-bot: I haz the power
Presubmit check for 1076723002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-09 12:15:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076723002/20001
5 years, 8 months ago (2015-04-09 12:22:02 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 12:26:10 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294737

Powered by Google App Engine
This is Rietveld 408576698