V8 Buildbot: Split x87 into builder/tester.

scripts/slave/recipe_modules/v8/builders.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Contains the bulk of the V8 builder configurations so they can be reused
 # from multiple recipes.
 
 from infra.libs.infra_types import freeze
 
 BUILDERS = {
@@ skipping 1008 matching lines @@
 ####### Category: FYI
       'V8 Linux - vtunejit': {
         'chromium_apply_config': ['vtunejit', 'v8_goma'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Debug',
           'TARGET_BITS': 32,
         },
         'bot_type': 'builder_tester',
         'testing': {'platform': 'linux'},
       },
+      'V8 Linux - x87 - nosnap - debug builder': {
+        'v8_apply_config': ['no_snapshot'],
+        'chromium_apply_config': ['no_snapshot', 'v8_goma', 'x87'],
+        'v8_config_kwargs': {
+          'BUILD_CONFIG': 'Debug',
+          'TARGET_BITS': 32,
+        },
+        'bot_type': 'builder',
+        'build_gs_archive': 'linux_x87_nosnap_dbg_archive',
+        'testing': {'platform': 'linux'},
+        'triggers': [
+          'V8 Linux - x87 - nosnap - debug',
+        ],
+      },
       'V8 Linux - x87 - nosnap - debug': {
         'v8_apply_config': ['no_snapshot'],
         'chromium_apply_config': ['no_snapshot', 'v8_goma', 'x87'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Debug',
           'TARGET_BITS': 32,
         },
-        'bot_type': 'builder_tester',
+        'bot_type': 'tester',
+        'parent_buildername': 'V8 Linux - debug builder',

[kjellander_chromium, 2015/04/09 09:17:14]

This should be 'V8 Linux - x87 - nosnap - debug builder' right?

[Michael Achenbach, 2015/04/09 09:19:30]

Totally :)

+        'build_gs_archive': 'linux_x87_nosnap_dbg_archive',
         'tests': ['unittests', 'v8testing'],
         'testing': {'platform': 'linux'},
       },
       'V8 Linux - predictable': {
         'v8_apply_config': ['predictable'],
         'chromium_apply_config': ['predictable', 'v8_goma'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 32,
         },
@@ skipping 421 matching lines @@
       'TARGET_BITS': 32,
     },
     'bot_type': 'builder',
     'build_gs_archive': 'v8_for_dart_archive',
     'testing': {'platform': platform},
   } for platform in ('win', 'linux', 'mac')
 }}
 
 BUILDERS = freeze(BUILDERS)
 BRANCH_BUILDERS = freeze(BRANCH_BUILDERS)