Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1076623002: Remove our impressive amount of CSS Cursor code. (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove our impressive amount of CSS Cursor code. With this gone, cursors will no longer change on hover when running Sky on a desktop. Then again the iGeneration doesn't probably even know what a mouse is, let alone have a burning desire to set a CSS3 custom-cursor. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a782487c5f35c269ce544967a4102ce96de0d2f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -1978 lines) Patch
M sky/engine/core/core.gni View 3 chunks +11 lines, -15 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
D sky/engine/core/css/CSSCursorImageValue.h View 1 chunk +0 lines, -76 lines 0 comments Download
D sky/engine/core/css/CSSCursorImageValue.cpp View 1 chunk +0 lines, -127 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -133 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSValue.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSValue.cpp View 5 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/css/CSSValueKeywords.in View 1 chunk +1 line, -39 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 2 chunks +0 lines, -73 lines 0 comments Download
M sky/engine/core/css/resolver/ElementStyleResources.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/ElementStyleResources.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +0 lines, -34 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResourceLoader.cpp View 3 chunks +0 lines, -17 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/core/page/ChromeClient.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 5 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 4 chunks +0 lines, -194 lines 0 comments Download
M sky/engine/core/page/Page.h View 4 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 3 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 3 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 3 chunks +0 lines, -21 lines 0 comments Download
D sky/engine/core/rendering/style/CursorData.h View 1 chunk +0 lines, -64 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 6 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -42 lines 0 comments Download
M sky/engine/core/rendering/style/StylePendingImage.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.cpp View 4 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 13 chunks +145 lines, -148 lines 0 comments Download
D sky/engine/platform/Cursor.h View 1 chunk +0 lines, -170 lines 0 comments Download
D sky/engine/platform/Cursor.cpp View 1 chunk +0 lines, -446 lines 0 comments Download
D sky/engine/platform/exported/WebCursorInfo.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M sky/engine/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/public/platform/WebCursorInfo.h View 1 chunk +0 lines, -123 lines 0 comments Download
M sky/engine/web/AssertMatchingEnums.cpp View 3 chunks +0 lines, -47 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 8 months ago (2015-04-08 21:17:07 UTC) #1
ojan
lgtm
5 years, 8 months ago (2015-04-08 21:22:58 UTC) #2
eseidel
5 years, 8 months ago (2015-04-08 21:23:18 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a782487c5f35c269ce544967a4102ce96de0d2f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698