Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: sky/engine/core/rendering/RenderObject.cpp

Issue 1076623002: Remove our impressive amount of CSS Cursor code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderObject.h ('k') | sky/engine/core/rendering/style/CursorData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderObject.cpp
diff --git a/sky/engine/core/rendering/RenderObject.cpp b/sky/engine/core/rendering/RenderObject.cpp
index b95a7f86e735f8797436d7897290a8a31efd3f7b..ecded5e1c55375dfd283408beeda25744ee48772 100644
--- a/sky/engine/core/rendering/RenderObject.cpp
+++ b/sky/engine/core/rendering/RenderObject.cpp
@@ -1251,17 +1251,6 @@ void RenderObject::styleWillChange(StyleDifference diff, const RenderStyle& newS
}
}
-static bool areNonIdenticalCursorListsEqual(const RenderStyle* a, const RenderStyle* b)
-{
- ASSERT(a->cursors() != b->cursors());
- return a->cursors() && b->cursors() && *a->cursors() == *b->cursors();
-}
-
-static inline bool areCursorsEqual(const RenderStyle* a, const RenderStyle* b)
-{
- return a->cursor() == b->cursor() && (a->cursors() == b->cursors() || areNonIdenticalCursorListsEqual(a, b));
-}
-
void RenderObject::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
{
if (s_affectsParentBlock) {
@@ -1294,11 +1283,6 @@ void RenderObject::styleDidChange(StyleDifference diff, const RenderStyle* oldSt
// Don't check for paint invalidation here; we need to wait until the layer has been
// updated by subclasses before we know if we have to invalidate paints (in setStyle()).
-
- if (oldStyle && !areCursorsEqual(oldStyle, style())) {
- if (LocalFrame* frame = this->frame())
- frame->eventHandler().scheduleCursorUpdate();
- }
}
void RenderObject::propagateStyleToAnonymousChildren(bool blockChildrenOnly)
@@ -1914,11 +1898,6 @@ PositionWithAffinity RenderObject::createPositionWithAffinity(const Position& po
return createPositionWithAffinity(0, DOWNSTREAM);
}
-CursorDirective RenderObject::getCursor(const LayoutPoint&, Cursor&) const
-{
- return SetCursorBasedOnStyle;
-}
-
bool RenderObject::canUpdateSelectionOnRootLineBoxes()
{
if (needsLayout())
« no previous file with comments | « sky/engine/core/rendering/RenderObject.h ('k') | sky/engine/core/rendering/style/CursorData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698