Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1076543002: Fix ink splashes in stocks app. (Closed)

Created:
5 years, 8 months ago by ojan
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix ink splashes in stocks app. https://codereview.chromium.org/1061163002 lost the default value of stretch for align-items on flex boxes. We used to have complicated rules where only flex boxes would default to stretch. Now that we only have flex boxes, we can just make it the default in RenderStyle. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f1ee38ea191b588a49bab81e62773bb1294d63bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
eseidel
5 years, 8 months ago (2015-04-08 19:26:26 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698