|
Remove all uses of display:block and display:inline-block.
-Make display:flex, flex-direction: column, flex-shrink: 1 the default.
-Simplify StyleAdjuster::adjustStyleForAlignment to remove special cases we
won't need as we make flex the default and remove absolute positioning.
-Fix a bug this exposed in column flexboxes where we'd apply the wrong edge
of border/padding/margin.
-For now leave the default of align-items:stretch. The main change here is
that iframe/img will do width:auto the same as blocks (i.e. the width of
the parent). I think this is a good change, but we'll have to see how it feels
in practice.
R=eseidel@chromium.org
Committed: https://chromium.googlesource.com/external/mojo/+/efa996dbae1fb7162316841f5a9f3eef58814e78
Total comments: 3
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+83 lines, -104 lines) |
Patch |
|
M |
sky/engine/core/css/parser/CSSPropertyParser.cpp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/engine/core/css/resolver/StyleAdjuster.cpp
|
View
|
|
1 chunk |
+6 lines, -40 lines |
3 comments
|
Download
|
|
M |
sky/engine/core/rendering/RenderFlexibleBox.cpp
|
View
|
|
3 chunks |
+5 lines, -10 lines |
0 comments
|
Download
|
|
M |
sky/engine/core/rendering/style/RenderStyle.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
sky/examples/stocks/lib/stock_arrow.dart
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/examples/stocks/lib/stock_row.dart
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/framework/components/action_bar.dart
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/framework/components/checkbox.dart
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/framework/components/floating_action_button.dart
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/framework/components/menu_item.dart
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
sky/framework/components/radio.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sky/framework/editing/editable_text.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sky/framework/elements/sky-checkbox.sky
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sky/framework/elements/sky-input.sky
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/framework/elements/sky-menu-item.sky
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
sky/framework/elements/sky-radio.sky
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sky/framework/elements/sky-toolbar.sky
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/tests/clipping/background-opaque-clipped-gradients-expected.txt
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sky/tests/editing/backspace.sky
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/tests/editing/replace.sky
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/tests/editing/selection.sky
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/tests/editing/typing.sky
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/tests/layout/continuations-expected.txt
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
sky/tests/layout/document-elementFromPoint.sky
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
sky/tests/layout/document-elementFromPoint-absolute-position.sky
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sky/tests/layout/ellipsis-expected.txt
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sky/tests/layout/fixed-width-expected.txt
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sky/tests/layout/position-absolute.sky
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/tests/layout/position-absolute-expected.txt
|
View
|
|
1 chunk |
+10 lines, -10 lines |
0 comments
|
Download
|
|
M |
sky/tests/layout/position-absolute-pixels.sky
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sky/tests/lowlevel/abarth-expected.txt
|
View
|
|
1 chunk |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
sky/tests/lowlevel/hello-world-expected.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sky/tests/lowlevel/home-expected.txt
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
sky/tests/lowlevel/iframe-expected.txt
|
View
|
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
sky/tests/lowlevel/img-expected.txt
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 4 (1 generated)
|