Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: build/common.gypi

Issue 107653002: Remove promises of clang flag-removal since clang isn't going to change. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index b1f041d4de40dace90dc0be646831a81fa6be443..4aeb68564cb731c467e60ee47834055be9ff1954 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2479,8 +2479,7 @@
'-Wno-format',
],
'cflags_cc!': [
- # TODO(fischman): remove this.
- # http://code.google.com/p/chromium/issues/detail?id=90453
+ # Necessary because llvm.org/PR10448 is WONTFIX (crbug.com/90453).
'-Wsign-compare',
]
}],
@@ -2929,9 +2928,7 @@
# Surprisingly, not covered by -fvisibility=hidden.
'-fvisibility-inlines-hidden',
# GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't,
- # so we specify it explicitly.
- # TODO(fischman): remove this if http://llvm.org/PR10448 obsoletes it.
- # http://code.google.com/p/chromium/issues/detail?id=90453
+ # so we specify it explicitly. (llvm.org/PR10448, crbug.com/90453)
'-Wsign-compare',
],
'ldflags': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698