Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: build/common.gypi

Issue 107653002: Remove promises of clang flag-removal since clang isn't going to change. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2461 matching lines...) Expand 10 before | Expand all | Expand 10 after
2472 'cflags_cc': [ 2472 'cflags_cc': [
2473 # Don't warn about hash_map in third-party code. 2473 # Don't warn about hash_map in third-party code.
2474 '-Wno-deprecated', 2474 '-Wno-deprecated',
2475 ], 2475 ],
2476 'cflags': [ 2476 'cflags': [
2477 # Don't warn about printf format problems. 2477 # Don't warn about printf format problems.
2478 # This is off by default in gcc but on in Ubuntu's gcc(!). 2478 # This is off by default in gcc but on in Ubuntu's gcc(!).
2479 '-Wno-format', 2479 '-Wno-format',
2480 ], 2480 ],
2481 'cflags_cc!': [ 2481 'cflags_cc!': [
2482 # TODO(fischman): remove this. 2482 # Necessary because llvm.org/PR10448 is WONTFIX (crbug.com/90453).
2483 # http://code.google.com/p/chromium/issues/detail?id=90453
2484 '-Wsign-compare', 2483 '-Wsign-compare',
2485 ] 2484 ]
2486 }], 2485 }],
2487 # TODO: Fix all warnings on chromeos too. 2486 # TODO: Fix all warnings on chromeos too.
2488 [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos== 1)', { 2487 [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos== 1)', {
2489 'cflags!': [ 2488 'cflags!': [
2490 '-Werror', 2489 '-Werror',
2491 ], 2490 ],
2492 }], 2491 }],
2493 [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', { 2492 [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', {
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
2922 '-fvisibility=hidden', 2921 '-fvisibility=hidden',
2923 '-pipe', 2922 '-pipe',
2924 ], 2923 ],
2925 'cflags_cc': [ 2924 'cflags_cc': [
2926 '-fno-rtti', 2925 '-fno-rtti',
2927 '-fno-threadsafe-statics', 2926 '-fno-threadsafe-statics',
2928 # Make inline functions have hidden visiblity by default. 2927 # Make inline functions have hidden visiblity by default.
2929 # Surprisingly, not covered by -fvisibility=hidden. 2928 # Surprisingly, not covered by -fvisibility=hidden.
2930 '-fvisibility-inlines-hidden', 2929 '-fvisibility-inlines-hidden',
2931 # GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't, 2930 # GCC turns on -Wsign-compare for C++ under -Wall, but clang doesn't,
2932 # so we specify it explicitly. 2931 # so we specify it explicitly. (llvm.org/PR10448, crbug.com/90453)
2933 # TODO(fischman): remove this if http://llvm.org/PR10448 obsoletes it.
2934 # http://code.google.com/p/chromium/issues/detail?id=90453
2935 '-Wsign-compare', 2932 '-Wsign-compare',
2936 ], 2933 ],
2937 'ldflags': [ 2934 'ldflags': [
2938 '-pthread', '-Wl,-z,noexecstack', 2935 '-pthread', '-Wl,-z,noexecstack',
2939 ], 2936 ],
2940 'libraries' : [ 2937 'libraries' : [
2941 '<(libraries_for_target)', 2938 '<(libraries_for_target)',
2942 ], 2939 ],
2943 'configurations': { 2940 'configurations': {
2944 'Debug_Base': { 2941 'Debug_Base': {
(...skipping 1851 matching lines...) Expand 10 before | Expand all | Expand 10 after
4796 # settings in target dicts. SYMROOT is a special case, because many other 4793 # settings in target dicts. SYMROOT is a special case, because many other
4797 # Xcode variables depend on it, including variables such as 4794 # Xcode variables depend on it, including variables such as
4798 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4795 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4799 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4796 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4800 # files to appear (when present) in the UI as actual files and not red 4797 # files to appear (when present) in the UI as actual files and not red
4801 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4798 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4802 # and therefore SYMROOT, needs to be set at the project level. 4799 # and therefore SYMROOT, needs to be set at the project level.
4803 'SYMROOT': '<(DEPTH)/xcodebuild', 4800 'SYMROOT': '<(DEPTH)/xcodebuild',
4804 }, 4801 },
4805 } 4802 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698