Issue 1076483002: ASan: Do not override strict_memcmp and replace_intrin in runtest.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1076483002: ASan: Do not override strict_memcmp and replace_intrin in runtest.py. (Closed)

Created:
5 years, 8 months ago by earthdok

Modified:
5 years, 8 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

More Reviews

Description

ASan: Do not override strict_memcmp and replace_intrin in runtest.py. replace_intrin=0 was relevant only on Mac, where we now have default sanitizer options. This means we no longer need to set it at runtime. strict_memcmp=0 may still be required on CrOS, where default options are not yet supported. However, the bug is reported to have been fixed, and this is the only way to check. BUG=178677, 162461, 302040 TBR=glider@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294724