scripts/slave/runtest.py - Issue 1076483002: ASan: Do not override strict_memcmp and replace_intrin in runtest.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/runtest.py

Issue 1076483002: ASan: Do not override strict_memcmp and replace_intrin in runtest.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/runtest.py

diff --git a/scripts/slave/runtest.py b/scripts/slave/runtest.py

index 0e382a504a36f589fa85b10995663372226a0b7b..90fd1240bc82636d28315928eca7631906c5fbe2 100755

--- a/scripts/slave/runtest.py

+++ b/scripts/slave/runtest.py

@@ -1740,12 +1740,7 @@ def _ConfigureSanitizerTools(options, args, extra_env):

# AddressSanitizer

if options.enable_asan:

- # Avoid aggressive memcmp checks until http://crbug.com/178677 is

- # fixed. Also do not replace memcpy/memmove/memset to suppress a

- # report in OpenCL, see http://crbug.com/162461.

- asan_options = symbolization_options + \

- ['strict_memcmp=0',

- 'replace_intrin=0']

+ asan_options = symbolization_options

if options.enable_lsan:

asan_options += ['detect_leaks=1']

AddToExistingEnv(extra_env, 'ASAN_OPTIONS', asan_options)

« no previous file with comments | « no previous file | no next file » | no next file with comments »