Source/modules/accessibility/AXMenuListPopup.h - Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXMenuListPopup.h

Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/accessibility/AXLayoutObject.cpp ('K') | « Source/modules/accessibility/AXMenuListOption.cpp ('k') | Source/modules/accessibility/AXMenuListPopup.cpp » ('j') | Source/modules/accessibility/AXObject.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXMenuListPopup.h

diff --git a/Source/modules/accessibility/AXMenuListPopup.h b/Source/modules/accessibility/AXMenuListPopup.h

index 0f543f75a323408e31d1ba2053b37b320ec1ddaa..5e75209808b70524c09229fcb7a93af8abb0544b 100644

--- a/Source/modules/accessibility/AXMenuListPopup.h

+++ b/Source/modules/accessibility/AXMenuListPopup.h

@@ -58,7 +58,7 @@ private:

virtual bool press() const override;

virtual void addChildren() override;

virtual void updateChildrenIfNecessary() override;

- virtual bool computeAccessibilityIsIgnored() const override;

+ virtual bool computeAccessibilityIsIgnored(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> = PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>>()) const override;

AXMenuListOption* menuListOptionAXObject(HTMLElement*) const;

int getSelectedIndex() const;