Source/modules/accessibility/AXMenuListPopup.cpp - Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXMenuListPopup.cpp

Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/accessibility/AXLayoutObject.cpp ('K') | « Source/modules/accessibility/AXMenuListPopup.h ('k') | Source/modules/accessibility/AXMockObject.h » ('j') | Source/modules/accessibility/AXObject.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXMenuListPopup.cpp

diff --git a/Source/modules/accessibility/AXMenuListPopup.cpp b/Source/modules/accessibility/AXMenuListPopup.cpp

index 0b2b490caaab4493887a6ac2ee72f57cad7a9d46..01733e4191437c2d011e3e730476cd3e0e4ee20b 100644

--- a/Source/modules/accessibility/AXMenuListPopup.cpp

+++ b/Source/modules/accessibility/AXMenuListPopup.cpp

@@ -60,9 +60,9 @@ bool AXMenuListPopup::isEnabled() const

return m_parent->isEnabled();

}

-bool AXMenuListPopup::computeAccessibilityIsIgnored() const

+bool AXMenuListPopup::computeAccessibilityIsIgnored(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> ignoredReasons) const

{

- return accessibilityIsIgnoredByDefault();

+ return accessibilityIsIgnoredByDefault(ignoredReasons);

}

AXMenuListOption* AXMenuListPopup::menuListOptionAXObject(HTMLElement* element) const