Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/ssl/certificate_error_report.h

Issue 1076273002: Add interstitial info to certificate reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: redo based on refactoring in crrev.com/1117173004 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/certificate_error_report.h
diff --git a/chrome/browser/ssl/certificate_error_report.h b/chrome/browser/ssl/certificate_error_report.h
index 9bc9b71c3d209bd1e601894a120738c0bc991af1..61830dcd28fdd70262988207d637a6637ce27543 100644
--- a/chrome/browser/ssl/certificate_error_report.h
+++ b/chrome/browser/ssl/certificate_error_report.h
@@ -20,6 +20,22 @@ class CertLoggerRequest;
// chrome_browser_net::CertificateErrorReporter.
class CertificateErrorReport {
public:
+ // Describes the type of interstitial that the user was shown for the
+ // error that this report represents. Gets mapped to
+ // |CertLoggerInterstitialInfo::InterstitialReason|.
+ enum InterstitialReason {
+ INTERSTITIAL_SSL,
+ INTERSTITIAL_CAPTIVE_PORTAL,
+ INTERSTITIAL_CLOCK
+ };
+
+ // Whether the user clicked through the interstitial or not.
+ enum ProceedDecision { USER_PROCEEDED, USER_DID_NOT_PROCEED };
+
+ // Whether the user was shown an option to click through the
+ // interstitial.
+ enum Overridable { INTERSTITIAL_OVERRIDABLE, INTERSTITIAL_NOT_OVERRIDABLE };
+
// Constructs an empty report.
CertificateErrorReport();
@@ -41,6 +57,10 @@ class CertificateErrorReport {
// successful and false otherwise.
bool Serialize(std::string* output) const;
+ void SetInterstitialInfo(const InterstitialReason& interstitial_reason,
+ const ProceedDecision& proceed_decision,
+ const Overridable& overridable);
+
// Gets the hostname to which this report corresponds.
const std::string& hostname() const;

Powered by Google App Engine
This is Rietveld 408576698