Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Unified Diff: chrome/browser/ssl/cert_logger.proto

Issue 1076273002: Add interstitial info to certificate reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: redo based on refactoring in crrev.com/1117173004 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/cert_logger.proto
diff --git a/chrome/browser/ssl/cert_logger.proto b/chrome/browser/ssl/cert_logger.proto
index 72549fd663625e4326c4cbf2f9eea04d8cc22070..b17836aeafcb344f216b0805de419543d867c242 100644
--- a/chrome/browser/ssl/cert_logger.proto
+++ b/chrome/browser/ssl/cert_logger.proto
@@ -20,6 +20,27 @@ syntax = "proto2";
option optimize_for = LITE_RUNTIME;
// Protocol types
+
+message CertLoggerInterstitialInfo {
+ // The different reasons that an SSL warning interstitial could be shown to
+ // a user.
+ enum InterstitialReason {
+ // A standard SSL interstitial
+ INTERSTITIAL_SSL = 1;
+ // An interstitial alerting the user that they are in a captive portal
+ INTERSTITIAL_CAPTIVE_PORTAL = 2;
+ // An interstitial telling the user to update their system clock
+ INTERSTITIAL_CLOCK = 3;
+ }
+
+ // The type of interstitial that was shown
+ optional InterstitialReason interstitial_reason = 1;
+ // True if the user clicked through to the offending website
+ optional bool user_proceeded = 2;
+ // True if the user was shown an option to click through
+ optional bool overridable = 3;
+}
+
message CertLoggerRequest {
// The hostname being accessed (required as the cert could be valid for
// multiple hosts, e.g. a wildcard or a SubjectAltName.
@@ -56,4 +77,8 @@ message CertLoggerRequest {
// Certificate errors encountered (if any) when validating this
// certificate chain.
repeated CertError cert_error = 6;
+
+ // Information about the interstitial that was shown to the user for
+ // this certificate error.
+ optional CertLoggerInterstitialInfo interstitial_info = 7;
};
« no previous file with comments | « no previous file | chrome/browser/ssl/certificate_error_report.h » ('j') | chrome/browser/ssl/ssl_blocking_page.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698