Chromium Code Reviews| Index: net/proxy/mojo_proxy_resolver_factory.h |
| diff --git a/net/proxy/mojo_proxy_resolver_factory.h b/net/proxy/mojo_proxy_resolver_factory.h |
| index eaf2774e800bd9ab874967eed0164642823d79f7..032985435d0cc085e43019949b56ea9e07365bda 100644 |
| --- a/net/proxy/mojo_proxy_resolver_factory.h |
| +++ b/net/proxy/mojo_proxy_resolver_factory.h |
| @@ -5,6 +5,8 @@ |
| #ifndef NET_PROXY_MOJO_PROXY_RESOLVER_FACTORY_H_ |
| #define NET_PROXY_MOJO_PROXY_RESOLVER_FACTORY_H_ |
| +#include "base/callback_helpers.h" |
| +#include "base/memory/scoped_ptr.h" |
| #include "net/interfaces/host_resolver_service.mojom.h" |
| #include "net/interfaces/proxy_resolver_service.mojom.h" |
| #include "third_party/mojo/src/mojo/public/cpp/bindings/interface_request.h" |
| @@ -15,10 +17,12 @@ namespace net { |
| class MojoProxyResolverFactory { |
| public: |
| // Connect to a new ProxyResolver service using request |req|, using |
| - // |host_resolver| as the DNS resolver. |
| + // |host_resolver| as the DNS resolver. The return value should be deleted |
|
eroman
2015/04/15 00:46:44
nit: deleted -> released (deleted sounds too much
Sam McNally
2015/04/15 06:04:22
Done.
|
| + // when the ProxyResolver client is deleted. |
| // Note: The connection request |req| may be resolved asynchronously. |
| - virtual void Create(mojo::InterfaceRequest<interfaces::ProxyResolver> req, |
| - interfaces::HostResolverPtr host_resolver) = 0; |
| + virtual scoped_ptr<base::ScopedClosureRunner> Create( |
| + mojo::InterfaceRequest<interfaces::ProxyResolver> req, |
| + interfaces::HostResolverPtr host_resolver) = 0; |
| protected: |
| virtual ~MojoProxyResolverFactory() = default; |