net/proxy/in_process_mojo_proxy_resolver_factory.cc - Issue 1076083002: Shut down proxy resolver utility processes when no longer needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/in_process_mojo_proxy_resolver_factory.cc

Issue 1076083002: Shut down proxy resolver utility processes when no longer needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proxy-service-with-factory-restart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc ('K') | « net/proxy/in_process_mojo_proxy_resolver_factory.h ('k') | net/proxy/mojo_proxy_resolver_factory.h » ('j') | net/proxy/mojo_proxy_resolver_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/proxy/in_process_mojo_proxy_resolver_factory.cc

diff --git a/net/proxy/in_process_mojo_proxy_resolver_factory.cc b/net/proxy/in_process_mojo_proxy_resolver_factory.cc

index da5f1138304cf80a97f5e97b69b1e953cc9ccb58..0652f3500cb9109ad0f60ac8f15092eaa0a678e7 100644

--- a/net/proxy/in_process_mojo_proxy_resolver_factory.cc

+++ b/net/proxy/in_process_mojo_proxy_resolver_factory.cc

@@ -25,10 +25,11 @@ InProcessMojoProxyResolverFactory::InProcessMojoProxyResolverFactory() {

InProcessMojoProxyResolverFactory::~InProcessMojoProxyResolverFactory() =

default;

-void InProcessMojoProxyResolverFactory::Create(

+scoped_ptr<base::ScopedClosureRunner> InProcessMojoProxyResolverFactory::Create(

mojo::InterfaceRequest<interfaces::ProxyResolver> req,

interfaces::HostResolverPtr host_resolver) {

factory_->CreateResolver(req.Pass(), host_resolver.Pass());

+ return nullptr;

}

} // namespace net