Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1075463002: win: Make MusicManagerPrivateTest.DeviceIdValueReturned work on swarming. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Make MusicManagerPrivateTest.DeviceIdValueReturned work on swarming. BUG=474873 Committed: https://crrev.com/8b02b52f5a7d65ba9fd034c6c1cd265bfa40a88c Cr-Commit-Position: refs/heads/master@{#324250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M chrome/browser/extensions/api/music_manager_private/music_manager_private_browsertest.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/music_manager_private/device_id_value_returned/chrometest.js View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 8 months ago (2015-04-08 15:28:43 UTC) #2
rpaquay
lgtm
5 years, 8 months ago (2015-04-08 15:40:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075463002/1
5 years, 8 months ago (2015-04-08 15:50:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 17:36:34 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 17:39:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b02b52f5a7d65ba9fd034c6c1cd265bfa40a88c
Cr-Commit-Position: refs/heads/master@{#324250}

Powered by Google App Engine
This is Rietveld 408576698