Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3879)

Unified Diff: chrome/test/data/extensions/platform_apps/music_manager_private/device_id_value_returned/chrometest.js

Issue 1075463002: win: Make MusicManagerPrivateTest.DeviceIdValueReturned work on swarming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/music_manager_private/music_manager_private_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/platform_apps/music_manager_private/device_id_value_returned/chrometest.js
diff --git a/chrome/test/data/extensions/platform_apps/music_manager_private/device_id_value_returned/chrometest.js b/chrome/test/data/extensions/platform_apps/music_manager_private/device_id_value_returned/chrometest.js
index 8d4539c1e4d5f7052e04982dbf9ea1c0138740da..93be223dc235178b2ffff449bf78b0369907e2bb 100644
--- a/chrome/test/data/extensions/platform_apps/music_manager_private/device_id_value_returned/chrometest.js
+++ b/chrome/test/data/extensions/platform_apps/music_manager_private/device_id_value_returned/chrometest.js
@@ -2,16 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-var deviceIdMaybeUndefined;
-
function runTests() {
chrome.test.runTests([
function test() {
chrome.musicManagerPrivate.getDeviceId(function(id) {
console.log('Device ID=' + id);
- if (!id) {
- chrome.test.assertEq(true, deviceIdMaybeUndefined)
- } else {
+ if (id) {
+ // This block is not entered in VMs (e.g. the bots) which return
+ // dummy MACs.
chrome.test.assertEq('string', typeof id);
chrome.test.assertTrue(id.length >= 8);
}
@@ -24,8 +22,6 @@ function runTests() {
window.onload = function() {
chrome.test.getConfig(function(config) {
console.log('customArg=' + config.customArg);
- deviceIdMaybeUndefined =
- (config.customArg === 'device_id_may_be_undefined');
runTests();
});
}
« no previous file with comments | « chrome/browser/extensions/api/music_manager_private/music_manager_private_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698