Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1075143002: Add perf test configuration to track memory use of context and isolate. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add perf test configuration to track memory use of context and isolate. R=machenbach@chromium.org Committed: https://crrev.com/c0593a1fc8519a8e0eaf3627fa12bcf4ba80e8a8 Cr-Commit-Position: refs/heads/master@{#27738}

Patch Set 1 #

Total comments: 1

Patch Set 2 : CamelCase names and addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A test/memory/Memory.json View 1 1 chunk +27 lines, -0 lines 0 comments Download
M tools/run_perf.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
Example output: $ tools/run_perf.py --outdir=out --buildbot test/memory/Memory.json >>> Running suite: Memory >>> Stdout (#1): Deserialization ...
5 years, 8 months ago (2015-04-10 09:03:09 UTC) #1
Michael Achenbach
https://codereview.chromium.org/1075143002/diff/1/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/1075143002/diff/1/tools/run_perf.py#newcode414 tools/run_perf.py:414: elif suite.get("main") != None: is not None
5 years, 8 months ago (2015-04-10 09:09:47 UTC) #2
Yang
On 2015/04/10 09:09:47, Michael Achenbach wrote: > https://codereview.chromium.org/1075143002/diff/1/tools/run_perf.py > File tools/run_perf.py (right): > > https://codereview.chromium.org/1075143002/diff/1/tools/run_perf.py#newcode414 ...
5 years, 8 months ago (2015-04-10 09:10:56 UTC) #3
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-10 09:17:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075143002/20001
5 years, 8 months ago (2015-04-10 09:23:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 09:49:00 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 09:49:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0593a1fc8519a8e0eaf3627fa12bcf4ba80e8a8
Cr-Commit-Position: refs/heads/master@{#27738}

Powered by Google App Engine
This is Rietveld 408576698