Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: tools/run_perf.py

Issue 1075143002: Add perf test configuration to track memory use of context and isolate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: CamelCase names and addressed comment Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/memory/Memory.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run_perf.py
diff --git a/tools/run_perf.py b/tools/run_perf.py
index f7710796bc3e7c651e4effcae031e1fd95eec129..84cc712308c60c7fb45b02067f6ddb347e15457b 100755
--- a/tools/run_perf.py
+++ b/tools/run_perf.py
@@ -411,8 +411,8 @@ def MakeGraph(suite, arch, parent):
if isinstance(parent, Runnable):
# Below a runnable can only be traces.
return Trace(suite, parent, arch)
- elif suite.get("main"):
- # A main file makes this graph runnable.
+ elif suite.get("main") is not None:
+ # A main file makes this graph runnable. Empty strings are accepted.
if suite.get("tests"):
# This graph has subgraphs (traces).
return Runnable(suite, parent, arch)
« no previous file with comments | « test/memory/Memory.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698