components/history/core/browser/history_backend.cc - Issue 1074963003: Clean up potentially leaky use of base::DeletePointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend.cc

Issue 1074963003: Clean up potentially leaky use of base::DeletePointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed another probleb Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/history/core/browser/history_backend.cc

diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc

index 5f2bd55a55640e81beb2089cf864c6710ee3d165..b56819dd97fa17f5b5b2003b2f9846218923b6ac 100644

--- a/components/history/core/browser/history_backend.cc

+++ b/components/history/core/browser/history_backend.cc

@@ -160,7 +160,7 @@ QueuedHistoryDBTask::~QueuedHistoryDBTask() {

// Ensure that |task_| is destroyed on its origin thread.

origin_loop_->PostTask(FROM_HERE,

base::Bind(&base::DeletePointer<HistoryDBTask>,

- base::Unretained(task_.release())));

+ base::Passed(&task_)));

}

bool QueuedHistoryDBTask::is_canceled() {

« no previous file with comments | « chromeos/network/firewall_hole.cc ('k') | content/browser/media/capture/web_contents_audio_input_stream.cc » ('j') | no next file with comments »