chromeos/network/firewall_hole.cc - Issue 1074963003: Clean up potentially leaky use of base::DeletePointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/firewall_hole.cc

Issue 1074963003: Clean up potentially leaky use of base::DeletePointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed another probleb Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_typed_url_unittest.cc ('k') | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/firewall_hole.cc

diff --git a/chromeos/network/firewall_hole.cc b/chromeos/network/firewall_hole.cc

index 425e423fe8c9a0e0559b28dbd3665393358b5572..09ee218d803581e4231da033e37f631cf5c13e5f 100644

--- a/chromeos/network/firewall_hole.cc

+++ b/chromeos/network/firewall_hole.cc

@@ -63,8 +63,10 @@ void PortReleased(FirewallHole::PortType type,

void CHROMEOS_EXPORT FirewallHole::FileDescriptorDeleter::operator()(

dbus::FileDescriptor* fd) {

+ scoped_ptr<dbus::FileDescriptor> owned_fd(fd);

base::WorkerPool::PostTask(

- FROM_HERE, base::Bind(&base::DeletePointer<dbus::FileDescriptor>, fd),

+ FROM_HERE, base::Bind(&base::DeletePointer<dbus::FileDescriptor>,

+ base::Passed(&owned_fd)),

false);

}