Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1074883005: [Effen] Tapping on a menu while it's closing should not make it instantly disappear. (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Tapping on a menu while it's closing should not make it instantly disappear. This tries to make the menu controller more careful about the state transitions it goes through, in particular, not firing off animations while we're already closing (since that used to trigger the "we're done animating" callback which then closes the menu forcibly). R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/886bdc087355f07eab3f1296f0656b5fff61df84

Patch Set 1 #

Patch Set 2 : fix enum case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M sky/framework/animation/animated_value.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/popup_menu.dart View 1 1 chunk +26 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 8 months ago (2015-04-23 19:58:03 UTC) #2
Hixie
5 years, 8 months ago (2015-04-23 20:20:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
886bdc087355f07eab3f1296f0656b5fff61df84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698