sky/framework/animation/animated_value.dart - Issue 1074883005: [Effen] Tapping on a menu while it's closing should not make it instantly disappear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/framework/animation/animated_value.dart

Issue 1074883005: [Effen] Tapping on a menu while it's closing should not make it instantly disappear. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: fix enum case Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/framework/animation/animated_value.dart

diff --git a/sky/framework/animation/animated_value.dart b/sky/framework/animation/animated_value.dart

index d07dac5646191c465fd2f2539a8581d0ae1ee61f..5b4cb3eee50da17e39003d87e795317c07772b96 100644

--- a/sky/framework/animation/animated_value.dart

+++ b/sky/framework/animation/animated_value.dart

@@ -47,7 +47,7 @@ class AnimatedValue {

void stop() {

if (_animation != null) {

- _animation.cancel();

+ _animation.cancel(); // will call _done() if it isn't already finished

_done();

}

« no previous file with comments | « no previous file | sky/framework/components/popup_menu.dart » ('j') | no next file with comments »