Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1074703002: Componentization: make core/dom visible for blink_web and blink_tests. (Closed)

Created:
5 years, 8 months ago by tasak
Modified:
5 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, chromiumbugtracker_adobe.com, webcomponents-bugzilla_chromium.org, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -37 lines) Patch
M Source/core/css/CSSFontSelectorClient.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/CSSSelectorWatch.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/CharacterData.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/ClientRectList.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/ContextFeatures.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentFragment.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/DocumentInit.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentLifecycle.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/DocumentLifecycleObserver.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/DocumentMarker.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/DocumentMarkerController.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Fullscreen.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/MainThreadTaskRunner.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Microtask.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/NodeRenderingTraversal.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/dom/PendingScript.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Range.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/RemoteSecurityContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/ScriptLoader.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/ScriptRunner.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/StyleEngine.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Text.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Touch.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/TouchList.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/ViewportDescription.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/custom/CustomElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementProcessingStack.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ComposedTreeTraversal.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tasak
PTAL?
5 years, 8 months ago (2015-04-09 08:48:31 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-09 08:55:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074703002/1
5 years, 8 months ago (2015-04-10 06:45:16 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 06:49:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193518

Powered by Google App Engine
This is Rietveld 408576698