Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: Source/core/dom/ContextFeatures.h

Issue 1074703002: Componentization: make core/dom visible for blink_web and blink_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/ClientRectList.h ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
11 * contributors may be used to endorse or promote products derived from 11 * contributors may be used to endorse or promote products derived from
12 * this software without specific prior written permission. 12 * this software without specific prior written permission.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 14 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
15 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 15 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
16 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 16 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
17 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 17 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
18 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 18 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
19 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 19 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
20 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 20 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
21 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 21 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
22 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #ifndef ContextFeatures_h 27 #ifndef ContextFeatures_h
28 #define ContextFeatures_h 28 #define ContextFeatures_h
29 29
30 #include "core/CoreExport.h"
30 #include "platform/RefCountedSupplement.h" 31 #include "platform/RefCountedSupplement.h"
31 32
32 namespace blink { 33 namespace blink {
33 34
34 class ContextFeaturesClient; 35 class ContextFeaturesClient;
35 class Document; 36 class Document;
36 class Page; 37 class Page;
37 38
38 #if ENABLE(OILPAN) 39 #if ENABLE(OILPAN)
39 class ContextFeatures final : public GarbageCollectedFinalized<ContextFeatures>, public HeapSupplement<Page> { 40 class ContextFeatures final : public GarbageCollectedFinalized<ContextFeatures>, public HeapSupplement<Page> {
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 class ContextFeaturesClient { 77 class ContextFeaturesClient {
77 WTF_MAKE_FAST_ALLOCATED(ContextFeaturesClient); 78 WTF_MAKE_FAST_ALLOCATED(ContextFeaturesClient);
78 public: 79 public:
79 static PassOwnPtr<ContextFeaturesClient> empty(); 80 static PassOwnPtr<ContextFeaturesClient> empty();
80 81
81 virtual ~ContextFeaturesClient() { } 82 virtual ~ContextFeaturesClient() { }
82 virtual bool isEnabled(Document*, ContextFeatures::FeatureType, bool default Value) { return defaultValue; } 83 virtual bool isEnabled(Document*, ContextFeatures::FeatureType, bool default Value) { return defaultValue; }
83 virtual void urlDidChange(Document*) { } 84 virtual void urlDidChange(Document*) { }
84 }; 85 };
85 86
86 void provideContextFeaturesTo(Page&, PassOwnPtr<ContextFeaturesClient>); 87 CORE_EXPORT void provideContextFeaturesTo(Page&, PassOwnPtr<ContextFeaturesClien t>);
87 void provideContextFeaturesToDocumentFrom(Document&, Page&); 88 void provideContextFeaturesToDocumentFrom(Document&, Page&);
88 89
89 inline PassRefPtrWillBeRawPtr<ContextFeatures> ContextFeatures::create(PassOwnPt r<ContextFeaturesClient> client) 90 inline PassRefPtrWillBeRawPtr<ContextFeatures> ContextFeatures::create(PassOwnPt r<ContextFeaturesClient> client)
90 { 91 {
91 return adoptRefWillBeNoop(new ContextFeatures(client)); 92 return adoptRefWillBeNoop(new ContextFeatures(client));
92 } 93 }
93 94
94 inline bool ContextFeatures::isEnabled(Document* document, FeatureType type, boo l defaultValue) const 95 inline bool ContextFeatures::isEnabled(Document* document, FeatureType type, boo l defaultValue) const
95 { 96 {
96 if (!m_client) 97 if (!m_client)
97 return defaultValue; 98 return defaultValue;
98 return m_client->isEnabled(document, type, defaultValue); 99 return m_client->isEnabled(document, type, defaultValue);
99 } 100 }
100 101
101 inline void ContextFeatures::urlDidChange(Document* document) 102 inline void ContextFeatures::urlDidChange(Document* document)
102 { 103 {
103 // FIXME: The original code, commented out below, is obviously 104 // FIXME: The original code, commented out below, is obviously
104 // wrong, but the seemingly correct fix of negating the test to 105 // wrong, but the seemingly correct fix of negating the test to
105 // the more logical 'if (!m_client)' crashes the renderer. 106 // the more logical 'if (!m_client)' crashes the renderer.
106 // See issue 294180 107 // See issue 294180
107 // 108 //
108 // if (m_client) 109 // if (m_client)
109 // return; 110 // return;
110 // m_client->urlDidChange(document); 111 // m_client->urlDidChange(document);
111 } 112 }
112 113
113 } // namespace blink 114 } // namespace blink
114 115
115 #endif // ContextFeatures_h 116 #endif // ContextFeatures_h
OLDNEW
« no previous file with comments | « Source/core/dom/ClientRectList.h ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698