components/autofill/core/browser/autofill_external_delegate.h - Issue 1074343004: get rid of another inappropriate ToLowerASCII

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 1074343004: get rid of another inappropriate ToLowerASCII (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nodeleteallowed

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate.h

diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h

index 8e8c32091474e370faeb121e2f5b6153f12b5efa..1f88ff0338be1cf631e50f47e901fcd032ee1801 100644

--- a/components/autofill/core/browser/autofill_external_delegate.h

+++ b/components/autofill/core/browser/autofill_external_delegate.h

@@ -42,7 +42,7 @@ class AutofillExternalDelegate : public AutofillPopupDelegate {

int identifier) override;

void DidAcceptSuggestion(const base::string16& value,

int identifier) override;

- void RemoveSuggestion(const base::string16& value, int identifier) override;

+ bool RemoveSuggestion(const base::string16& value, int identifier) override;

void ClearPreviewedForm() override;

// Records and associates a query_id with web form data. Called