Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2634)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

Issue 1074343004: get rid of another inappropriate ToLowerASCII (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nodeleteallowed
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
index 71e262aa36d1f5a6e5a69a561fadf426267bfb25..122bcd9081e6ee0d1fa250f97980ac7291e90ea5 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
@@ -47,7 +47,9 @@ class MockAutofillExternalDelegate : public AutofillExternalDelegate {
void DidSelectSuggestion(const base::string16& value,
int identifier) override {}
- void RemoveSuggestion(const base::string16& value, int identifier) override {}
+ bool RemoveSuggestion(const base::string16& value, int identifier) override {
+ return true;
+ }
void ClearPreviewedForm() override {}
base::WeakPtr<AutofillExternalDelegate> GetWeakPtr() {
return AutofillExternalDelegate::GetWeakPtr();
@@ -248,12 +250,6 @@ TEST_F(AutofillPopupControllerUnitTest, RemoveLine) {
// No line is selected so the removal should fail.
EXPECT_FALSE(autofill_popup_controller_->RemoveSelectedLine());
- // Try to remove the last entry and ensure it fails (it is an option).
- autofill_popup_controller_->SetSelectedLine(
- autofill_popup_controller_->GetLineCount() - 1);
- EXPECT_FALSE(autofill_popup_controller_->RemoveSelectedLine());
- EXPECT_LE(0, autofill_popup_controller_->selected_line());
-
// Remove the first entry. The popup should be redrawn since its size has
// changed.
EXPECT_CALL(*autofill_popup_controller_, UpdateBoundsAndRedrawPopup());

Powered by Google App Engine
This is Rietveld 408576698