Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: extensions/renderer/dispatcher.cc

Issue 1074273002: Move the event attach/detach logic on unload from event.js to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: being process of relanding - more test assertions Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index c61b18897e8f8a1156f08a285d020203422925c4..46abc4326c6cefaefb56e1398dd6e9c882a46295 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -365,7 +365,8 @@ void Dispatcher::WillReleaseScriptContext(
return;
context->DispatchOnUnloadEvent();
- // TODO(kalman): add an invalidation observer interface to ScriptContext.
+ // TODO(kalman): Make |request_sender| use |context->AddInvalidationObserver|.
+ // In fact |request_sender_| should really be owned by ScriptContext.
request_sender_->InvalidateSource(context);
script_context_set_.Remove(context);
« no previous file with comments | « chrome/test/data/extensions/api_test/events_are_unregistered/page2.js ('k') | extensions/renderer/event_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698