chrome/test/data/extensions/api_test/events_are_unregistered/page2.js - Issue 1074273002: Move the event attach/detach logic on unload from event.js to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/events_are_unregistered/page2.js

Issue 1074273002: Move the event attach/detach logic on unload from event.js to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: being process of relanding - more test assertions Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/events_are_unregistered/page2.js

diff --git a/chrome/test/data/extensions/error_console/runtime_and_manifest_errors/script.js b/chrome/test/data/extensions/api_test/events_are_unregistered/page2.js

similarity index 71%

copy from chrome/test/data/extensions/error_console/runtime_and_manifest_errors/script.js

copy to chrome/test/data/extensions/api_test/events_are_unregistered/page2.js

index 214ab10e201f37844274f6f20052897d14a12ab7..26e65dfe37740ada74f9b1790559b4ee2e761104 100644

--- a/chrome/test/data/extensions/error_console/runtime_and_manifest_errors/script.js

+++ b/chrome/test/data/extensions/api_test/events_are_unregistered/page2.js

@@ -2,5 +2,5 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-console.log('line1');

-console.log('line2');

+// See page1.js to make sense of this.

+chrome.test.notifyPass();

« no previous file with comments | « chrome/test/data/extensions/api_test/events_are_unregistered/page2.html ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »