Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 1074123004: MIPS: Fix for StringCharCodeAtGenerator for vector-ics. (Closed)

Created:
5 years, 8 months ago by paul.l...
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix for StringCharCodeAtGenerator for vector-ics. Register pop order bug only surfaced after vector-ic optimization in https://codereview.chromium.org/1053843003 was landed. TEST=mjsunit/string-index.js BUG= Committed: https://crrev.com/e8fe70492102377a0aed8b18f760f839d00d52c9 Cr-Commit-Position: refs/heads/master@{#27894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL.
5 years, 8 months ago (2015-04-16 02:28:35 UTC) #2
mvstanton
Awesome to find this! LGTM.
5 years, 8 months ago (2015-04-16 06:29:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074123004/1
5 years, 8 months ago (2015-04-16 15:33:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 16:07:01 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 16:07:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8fe70492102377a0aed8b18f760f839d00d52c9
Cr-Commit-Position: refs/heads/master@{#27894}

Powered by Google App Engine
This is Rietveld 408576698