Issue 107393002: Convert a few tests from CRLF to LF line endings

Issue 107393002: Convert a few tests from CRLF to LF line endings (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
arv (Not doing code reviews)

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Convert a few tests from CRLF to LF line endings The CRLF line endings seemingly cause the apply_issue step to fail in trybot runs for https://codereview.chromium.org/106773003 BUG=none R=arv@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163305

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -91 lines)			Patch
	M	LayoutTests/editing/style/bold-with-dom-changes.html	View		1 chunk	+42 lines, -42 lines	0 comments	Download
	M	LayoutTests/fast/dom/node-iterator-reference-node-moved-crash.html	View		1 chunk	+48 lines, -49 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/107393002/1

7 years ago (2013-12-05 23:04:54 UTC) #3

commit-bot: I haz the power

Failed to apply patch for LayoutTests/editing/style/bold-with-dom-changes.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years ago (2013-12-05 23:04:55 UTC) #4

Failed to apply patch for LayoutTests/editing/style/bold-with-dom-changes.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/editing/style/bold-with-dom-changes.html
  Hunk #1 FAILED at 1.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/editing/style/bold-with-dom-changes.html.rej

Patch:       LayoutTests/editing/style/bold-with-dom-changes.html
Index: LayoutTests/editing/style/bold-with-dom-changes.html
diff --git a/LayoutTests/editing/style/bold-with-dom-changes.html
b/LayoutTests/editing/style/bold-with-dom-changes.html
index
6ebb23044b5b7c1b978837332c395efee216fb8c..3793f6f79f69bcb4f2f57747900b1a43c46eaee4
100644
--- a/LayoutTests/editing/style/bold-with-dom-changes.html
+++ b/LayoutTests/editing/style/bold-with-dom-changes.html
@@ -1,42 +1,42 @@
-<!DOCTYPE html>
-<html>
-<body>
-This test verifies that deleting DOM elements in a DOMSubtreeModified handler
triggered by and execCommand('bold') does not produce a crash.
-<div id="test" contenteditable style="border: 1px solid red">
-<b class="x" id="inlined">
-    <u></u>
-    x
-</b>
-</div>
-<script>
-function treeModifiedHandler()
-{
-    document.removeEventListener("DOMSubtreeModified", treeModifiedHandler,
false);
-
-    var b = document.getElementById("inlined");
-    b.insertBefore(document.createTextNode(), b.firstChild);
-
-    var range = document.createRange();
-    range.setStart(b,0);
-    range.setEnd(b,2);
-    range.deleteContents();
-    document.body.appendChild(document.createTextNode("PASS"));
-}
-
-function runtest()
-{
-    var test = document.getElementById('test');
-    window.getSelection().selectAllChildren(test);
-
-    document.execCommand('bold', false, null);
-    document.addEventListener("DOMSubtreeModified", treeModifiedHandler,
false);
-    document.execCommand('bold', false, null);
-}
-
-if (window.testRunner)
-    testRunner.dumpAsText();
-
-runtest();
-</script>
-</body>
-</html>
+<!DOCTYPE html>
+<html>
+<body>
+This test verifies that deleting DOM elements in a DOMSubtreeModified handler
triggered by and execCommand('bold') does not produce a crash.
+<div id="test" contenteditable style="border: 1px solid red">
+<b class="x" id="inlined">
+    <u></u>
+    x
+</b>
+</div>
+<script>
+function treeModifiedHandler()
+{
+    document.removeEventListener("DOMSubtreeModified", treeModifiedHandler,
false);
+
+    var b = document.getElementById("inlined");
+    b.insertBefore(document.createTextNode(), b.firstChild);
+
+    var range = document.createRange();
+    range.setStart(b,0);
+    range.setEnd(b,2);
+    range.deleteContents();
+    document.body.appendChild(document.createTextNode("PASS"));
+}
+
+function runtest()
+{
+    var test = document.getElementById('test');
+    window.getSelection().selectAllChildren(test);
+
+    document.execCommand('bold', false, null);
+    document.addEventListener("DOMSubtreeModified", treeModifiedHandler,
false);
+    document.execCommand('bold', false, null);
+}
+
+if (window.testRunner)
+    testRunner.dumpAsText();
+
+runtest();
+</script>
+</body>
+</html>

philipj_slow

7 years ago (2013-12-06 08:34:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r163305 (presubmit successful).

Expand Messages | Collapse Messages