Issue 106773003: Make arguments to Document methods non-optional

Issue 106773003: Make arguments to Document methods non-optional (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make arguments to Document methods non-optional http://dom.spec.whatwg.org/#interface-document Only touch methods defined by the above spec. The added missing-arguments test passes in Firefox Nightly, IE11 Release Preview and Opera 12.16, so there ought to be fairly little Web content depending on the old behavior. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163341

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -77 lines)			Patch
M	LayoutTests/compositing/geometry/assert-marquee-timer.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/editing/style/bold-with-dom-changes.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/Document/createElementNS-namespace-err-expected.txt	View		4 chunks	+6 lines, -8 lines	0 comments	Download
A	LayoutTests/fast/dom/Document/missing-arguments.html	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Document/missing-arguments-expected.txt	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Document/script-tests/createElementNS-namespace-err.js	View		3 chunks	+4 lines, -8 lines	0 comments	Download
M	LayoutTests/fast/dom/MutationObserver/observe-characterdata.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/attribute-downcast-right.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/dom-method-document-change.html	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/dom/getElementsByClassName/dumpNodeList.html	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/getElementsByClassName/dumpNodeList-expected.txt	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/id-attribute-shared.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/node-iterator-reference-node-moved-crash.html	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/normalize-attributes-mutation-event-crash.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/null-chardata-crash.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/wrapper-classes.html	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/wrapper-classes-expected.txt	View		3 chunks	+12 lines, -12 lines	0 comments	Download
M	LayoutTests/fast/forms/basic-textareas.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/inspector-support/uncaught-dom1-exception.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/inspector-support/uncaught-dom3-exception.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/inspector-support/uncaught-dom3-exception-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/pointer-lock/pointer-lock-api.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/svg/dom/vkern-element-crash.html	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/Document.idl	View		3 chunks	+14 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/106773003/40001

7 years ago (2013-12-06 09:45:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/106773003/40001

7 years ago (2013-12-06 13:04:49 UTC) #4

Message was sent while issue was closed.

Change committed as 163341

Expand Messages | Collapse Messages