Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1073913004: Revert of Encrypt certificate reports before uploading to HTTP URLs (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 8 months ago
Reviewers:
agl, mattm, felt, estark
CC:
chromium-reviews, cbentzel+watch_chromium.org, felt
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Encrypt certificate reports before uploading to HTTP URLs (patchset #20 id:400001 of https://codereview.chromium.org/1083493003/) Reason for revert: This CL broke the Win8 GN bot: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/6514 Original issue's description: > Encrypt certificate reports before uploading to HTTP URLs > > This CL introduces a new protobuf to store encrypted > CertLoggerRequests. Serialized certificate reports are encrypted with an > AES-CTR-128-HMAC-SHA256 AEAD (from BoringSSL, thus encrypted reports are > only supported on BoringSSL platforms) before being uploaded to HTTP > endpoints. |CertificateErrorReporter::IsHttpUploadUrlSupported| allows > users of the class to set an HTTP URL if supported. > > BUG=461590 > > Committed: https://crrev.com/0a3351c2a7c81284f82e6531380a21d079f55056 > Cr-Commit-Position: refs/heads/master@{#326876} TBR=agl@chromium.org,felt@chromium.org,mattm@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461590 Committed: https://crrev.com/7f606b38af8a2897d0490ede6f1e745c31523409 Cr-Commit-Position: refs/heads/master@{#326878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -501 lines) Patch
M chrome/browser/net/cert_logger.proto View 2 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/net/certificate_error_reporter.h View 6 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/net/certificate_error_reporter.cc View 5 chunks +6 lines, -144 lines 0 comments Download
M chrome/browser/net/certificate_error_reporter_unittest.cc View 10 chunks +9 lines, -59 lines 0 comments Download
M chrome/browser/safe_browsing/ping_manager.cc View 2 chunks +10 lines, -20 lines 0 comments Download
D crypto/aead_openssl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D crypto/aead_openssl.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D crypto/aead_openssl_unittest.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M crypto/crypto.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M crypto/crypto.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Donnelly
Created Revert of Encrypt certificate reports before uploading to HTTP URLs
5 years, 8 months ago (2015-04-24 21:28:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073913004/1
5 years, 8 months ago (2015-04-24 21:29:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 21:31:08 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:32:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f606b38af8a2897d0490ede6f1e745c31523409
Cr-Commit-Position: refs/heads/master@{#326878}

Powered by Google App Engine
This is Rietveld 408576698