Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: chrome/browser/net/certificate_error_reporter.h

Issue 1073913004: Revert of Encrypt certificate reports before uploading to HTTP URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/cert_logger.proto ('k') | chrome/browser/net/certificate_error_reporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/certificate_error_reporter.h
diff --git a/chrome/browser/net/certificate_error_reporter.h b/chrome/browser/net/certificate_error_reporter.h
index cba431f640e49960fc011f0393ccef4bfb300bdd..3c20ec1c607abe8bd12edc60e4caa39973808ab6 100644
--- a/chrome/browser/net/certificate_error_reporter.h
+++ b/chrome/browser/net/certificate_error_reporter.h
@@ -21,7 +21,6 @@
namespace chrome_browser_net {
class CertLoggerRequest;
-class EncryptedCertLoggerRequest;
// Provides functionality for sending reports about invalid SSL
// certificate chains to a report collection server.
@@ -49,13 +48,6 @@
const GURL& upload_url,
CookiesPreference cookies_preference);
- // Allows tests to use a server public key with known private key.
- CertificateErrorReporter(net::URLRequestContext* request_context,
- const GURL& upload_url,
- CookiesPreference cookies_preference,
- const uint8 server_public_key[32],
- const uint32 server_public_key_version);
-
~CertificateErrorReporter() override;
// Construct, serialize, and send a certificate report to the report
@@ -66,11 +58,6 @@
// responsible for enforcing any preconditions (such as obtaining user
// opt-in, only sending reports for certain hostnames, checking for
// incognito mode, etc.).
- //
- // On some platforms (but not all), CertificateErrorReporter can use
- // an HTTP endpoint to send encrypted extended reporting reports. On
- // unsupported platforms, callers must send extended reporting reports
- // over SSL.
virtual void SendReport(ReportType type,
const std::string& hostname,
const net::SSLInfo& ssl_info);
@@ -78,16 +65,6 @@
// net::URLRequest::Delegate
void OnResponseStarted(net::URLRequest* request) override;
void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
-
- // Callers can use this method to determine if sending reports over
- // HTTP is supported.
- static bool IsHttpUploadUrlSupported();
-
- // Used by tests.
- static bool DecryptCertificateErrorReport(
- const uint8 server_private_key[32],
- const EncryptedCertLoggerRequest& encrypted_report,
- CertLoggerRequest* decrypted_report);
private:
// Create a URLRequest with which to send a certificate report to the
@@ -98,8 +75,6 @@
// Serialize and send a CertLoggerRequest protobuf to the report
// collection server.
void SendCertLoggerRequest(const CertLoggerRequest& request);
-
- void SendSerializedRequest(const std::string& serialized_request);
// Populate the CertLoggerRequest for a report.
static void BuildReport(const std::string& hostname,
@@ -117,9 +92,6 @@
CookiesPreference cookies_preference_;
- const uint8* server_public_key_;
- const uint32 server_public_key_version_;
-
DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter);
};
« no previous file with comments | « chrome/browser/net/cert_logger.proto ('k') | chrome/browser/net/certificate_error_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698