Fix C++ violation.

include/v8-profiler.h

Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index 4d8dc22fb2047e686a18f9d18cce1e86476198a2..bb1a9b09b9fff233b473250b946055b7d5fc2230 100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -25,22 +25,20 @@ struct CpuProfileDeoptFrame {
 };
 
 
-#ifdef V8_OS_WIN
-template class V8_EXPORT std::vector<CpuProfileDeoptFrame>;
-#endif
-
-
 struct V8_EXPORT CpuProfileDeoptInfo {
   /** A pointer to a static string owned by v8. */
   const char* deopt_reason;
   std::vector<CpuProfileDeoptFrame> stack;

[loislo, 2015/04/09 20:23:21]

template class needs to be defined before the first usage. Otherwise
win_no_snapshot bot fails.

[Nico, 2015/04/09 20:50:11]

Yeah, I just noticed. I have set up a v8 upstream build on my local windows box,
patched in this CL, reproduced the problem, verified that doing it in two pieces
fixes things, and I'm currently waiting for v8's lengthy presubmit checks to
pass so that `git cl upload` on my win box can complete. Patch set 2 should
appear very soon.

 };
 
+}  // namespace v8
 
 #ifdef V8_OS_WIN
-template class V8_EXPORT std::vector<CpuProfileDeoptInfo>;
+template class V8_EXPORT std::vector<v8::CpuProfileDeoptFrame>;
+template class V8_EXPORT std::vector<v8::CpuProfileDeoptInfo>;
 #endif
 
+namespace v8 {
 
 /**
  * CpuProfileNode represents a node in a call graph.