Fix C++ violation.

include/v8-profiler.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_V8_PROFILER_H_
 #define V8_V8_PROFILER_H_
 
 #include <vector>
 #include "v8.h"
 
 /**
  * Profiler support for the V8 JavaScript engine.
  */
 namespace v8 {
 
 class HeapGraphNode;
 struct HeapStatsUpdate;
 
 typedef uint32_t SnapshotObjectId;
 
 
 struct CpuProfileDeoptFrame {
   int script_id;
   size_t position;
 };
 
 
-#ifdef V8_OS_WIN
-template class V8_EXPORT std::vector<CpuProfileDeoptFrame>;
-#endif
-
-
 struct V8_EXPORT CpuProfileDeoptInfo {
   /** A pointer to a static string owned by v8. */
   const char* deopt_reason;
   std::vector<CpuProfileDeoptFrame> stack;

[loislo, 2015/04/09 20:23:21]

template class needs to be defined before the first usage. Otherwise
win_no_snapshot bot fails.

[Nico, 2015/04/09 20:50:11]

Yeah, I just noticed. I have set up a v8 upstream build on my local windows box,
patched in this CL, reproduced the problem, verified that doing it in two pieces
fixes things, and I'm currently waiting for v8's lengthy presubmit checks to
pass so that `git cl upload` on my win box can complete. Patch set 2 should
appear very soon.

 };
 
+}  // namespace v8
 
 #ifdef V8_OS_WIN
-template class V8_EXPORT std::vector<CpuProfileDeoptInfo>;
+template class V8_EXPORT std::vector<v8::CpuProfileDeoptFrame>;
+template class V8_EXPORT std::vector<v8::CpuProfileDeoptInfo>;
 #endif
 
+namespace v8 {
 
 /**
  * CpuProfileNode represents a node in a call graph.
  */
 class V8_EXPORT CpuProfileNode {
  public:
   struct LineTick {
     /** The 1-based number of the source line where the function originates. */
     int line;
 
@@ skipping 579 matching lines @@
   uint32_t index;  // Index of the time interval that was changed.
   uint32_t count;  // New value of count field for the interval with this index.
   uint32_t size;  // New value of size field for the interval with this index.
 };
 
 
 }  // namespace v8
 
 
 #endif  // V8_V8_PROFILER_H_