Fix C++ violation.

Fix C++ violation.

gcc rejects the following snippet, clang rejects it in -std=c++11 mode:
  namespace A { template<class T> class C {}; }
  namespace B { template class A::C<int>; }

Indeed, the C++ standard says in 14.7.2p2 "An explicit instantiation shall
appear in an enclosing namespace of its template", so cl.exe is incorrect to
allow this.

Just move the instantiation out of the v8 namespace to fix.  No intended
behavior change.  Fixes building with clang-cl on Windows.

BUG=chromium:475643
LOG=N
TBR=svenpanne@chromium.org

Committed: https://crrev.com/1f7a7b32d721cd48447017340961bf5ec80d199a
Cr-Commit-Position: refs/heads/master@{#27721}

[Nico, 2015-04-09 19:53:12]

thakis@chromium.org changed reviewers:
+ loislo@chromium.org

[Nico, 2015-04-09 19:55:09]

thakis@chromium.org changed reviewers:
+ svenpanne@chromium.org

[Nico, 2015-04-09 19:55:09]

sorry, i meant to put sven into the reviewers box, not the cc box

[loislo, 2015-04-09 20:23:21]

https://codereview.chromium.org/1073903002/diff/1/include/v8-profiler.h
File include/v8-profiler.h (left):

https://codereview.chromium.org/1073903002/diff/1/include/v8-profiler.h#oldco...
include/v8-profiler.h:36: std::vector<CpuProfileDeoptFrame> stack;
template class needs to be defined before the first usage. Otherwise
win_no_snapshot bot fails.

[Nico, 2015-04-09 20:50:11]

…and there it is. ptal.

https://codereview.chromium.org/1073903002/diff/1/include/v8-profiler.h
File include/v8-profiler.h (left):

https://codereview.chromium.org/1073903002/diff/1/include/v8-profiler.h#oldco...
include/v8-profiler.h:36: std::vector<CpuProfileDeoptFrame> stack;
On 2015/04/09 20:23:21, loislo wrote:
> template class needs to be defined before the first usage. Otherwise
> win_no_snapshot bot fails.

Yeah, I just noticed. I have set up a v8 upstream build on my local windows box,
patched in this CL, reproduced the problem, verified that doing it in two pieces
fixes things, and I'm currently waiting for v8's lengthy presubmit checks to
pass so that `git cl upload` on my win box can complete. Patch set 2 should
appear very soon.

[Michael Achenbach, 2015-04-09 21:11:41]

I'll add a TBR to Sven and push this through to cherry-pick it on the current
roll.

[Michael Achenbach, 2015-04-09 21:18:41]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-04-09 21:19:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1073903002/20001

[commit-bot: I haz the power, 2015-04-09 21:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-09 21:19:09]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Michael Achenbach, 2015-04-09 21:20:40]

lgtm

[Michael Achenbach, 2015-04-09 21:20:43]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-04-09 21:21:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1073903002/20001

[commit-bot: I haz the power, 2015-04-09 21:22:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-09 21:23:07]

Patchset 2 (id:??) landed as
https://crrev.com/1f7a7b32d721cd48447017340961bf5ec80d199a
Cr-Commit-Position: refs/heads/master@{#27721}