Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 107383002: Use base namespace for string16 in components and cloud_print. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
Scott Byer
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Use base namespace for string16 in components and cloud_print. R=scottbyer@chromium.org TBR=scottbyer Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239255

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -194 lines) Patch
M cloud_print/common/win/cloud_print_utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cloud_print/common/win/cloud_print_utils.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M cloud_print/common/win/install_utils.h View 1 chunk +9 lines, -8 lines 0 comments Download
M cloud_print/common/win/install_utils.cc View 7 chunks +11 lines, -10 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 6 chunks +11 lines, -10 lines 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 1 8 chunks +16 lines, -15 lines 0 comments Download
M cloud_print/service/win/local_security_policy.h View 1 chunk +4 lines, -3 lines 0 comments Download
M cloud_print/service/win/local_security_policy.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M cloud_print/service/win/service_controller.h View 2 chunks +9 lines, -9 lines 0 comments Download
M cloud_print/service/win/service_controller.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M cloud_print/service/win/service_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/service_utils.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M cloud_print/service/win/setup_listener.h View 3 chunks +4 lines, -4 lines 0 comments Download
M cloud_print/service/win/setup_listener.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_helpers.h View 1 chunk +3 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_helpers.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_address.cc View 8 chunks +28 lines, -28 lines 0 comments Download
M components/autofill/core/browser/autocomplete_history_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_field_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/validation.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/common/form_field_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/password_form.h View 2 chunks +9 lines, -9 lines 0 comments Download
M components/breakpad/app/hard_error_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/distiller_page_web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/distiller_page_web_contents.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/policy_error_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/browser/policy_error_map.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/registry_dict_win.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/registry_dict_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/serialized_navigation_entry.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/sessions/serialized_navigation_entry.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sessions/serialized_navigation_entry_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/webdata/common/web_data_results.h View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/wifi_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years ago (2013-12-05 22:37:05 UTC) #1
Scott Byer
LGTM w/ nits. https://codereview.chromium.org/107383002/diff/1/cloud_print/service/win/cloud_print_service.cc File cloud_print/service/win/cloud_print_service.cc (right): https://codereview.chromium.org/107383002/diff/1/cloud_print/service/win/cloud_print_service.cc#newcode85 cloud_print/service/win/cloud_print_service.cc:85: base::string16 prompt_format = cloud_print::LoadLocalString(string_id) ; nit: ...
7 years ago (2013-12-06 17:28:05 UTC) #2
brettw
7 years ago (2013-12-06 20:43:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r239255.

Powered by Google App Engine
This is Rietveld 408576698