Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: cloud_print/service/win/cloud_print_service.cc

Issue 107383002: Use base namespace for string16 in components and cloud_print. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cloud_print/service/win/chrome_launcher.cc ('k') | cloud_print/service/win/cloud_print_service_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/service/win/cloud_print_service.cc
diff --git a/cloud_print/service/win/cloud_print_service.cc b/cloud_print/service/win/cloud_print_service.cc
index 32fbe802413360152b96a8ae5179025d7f4458b2..e0998f0cf08463c7e7094da6ca98e306f64024f6 100644
--- a/cloud_print/service/win/cloud_print_service.cc
+++ b/cloud_print/service/win/cloud_print_service.cc
@@ -80,12 +80,12 @@ void InvalidUsage() {
std::cout << "\n";
}
-string16 GetOption(int string_id, const string16& default,
+base::string16 GetOption(int string_id, const base::string16& default,
bool secure) {
- string16 prompt_format = cloud_print::LoadLocalString(string_id) ;
- std::vector<string16> substitutions(1, default);
+ base::string16 prompt_format = cloud_print::LoadLocalString(string_id);
+ std::vector<base::string16> substitutions(1, default);
std::cout << ReplaceStringPlaceholders(prompt_format, substitutions, NULL);
- string16 tmp;
+ base::string16 tmp;
if (secure) {
DWORD saved_mode = 0;
// Don't close.
@@ -110,7 +110,7 @@ HRESULT ReportError(HRESULT hr, int string_id) {
return hr;
}
-string16 StateAsString(ServiceController::State state) {
+base::string16 StateAsString(ServiceController::State state) {
DWORD string_id = 0;
switch(state) {
case ServiceController::STATE_NOT_FOUND:
@@ -123,7 +123,7 @@ string16 StateAsString(ServiceController::State state) {
string_id = IDS_SERVICE_RUNNING;
break;
}
- return string_id ? cloud_print::LoadLocalString(string_id) : string16();
+ return string_id ? cloud_print::LoadLocalString(string_id) : base::string16();
}
} // namespace
@@ -214,8 +214,8 @@ class CloudPrintServiceModule
return controller_->UninstallService();
if (command_line.HasSwitch(kInstallSwitch)) {
- string16 run_as_user;
- string16 run_as_password;
+ base::string16 run_as_user;
+ base::string16 run_as_password;
base::FilePath user_data_dir;
std::vector<std::string> printers;
HRESULT hr = SelectWindowsAccount(&run_as_user, &run_as_password,
@@ -262,7 +262,8 @@ class CloudPrintServiceModule
return S_FALSE;
}
- HRESULT SelectWindowsAccount(string16* run_as_user, string16* run_as_password,
+ HRESULT SelectWindowsAccount(base::string16* run_as_user,
+ base::string16* run_as_password,
base::FilePath* user_data_dir,
std::vector<std::string>* printers) {
*run_as_user = GetCurrentUserName();
@@ -339,7 +340,7 @@ class CloudPrintServiceModule
LOG(INFO) << file.value() << ": " << contents;
- string16 message =
+ base::string16 message =
cloud_print::LoadLocalString(IDS_ADD_PRINTERS_USING_CHROME);
std::cout << "\n" << message.c_str() << "\n" ;
std::string new_contents =
« no previous file with comments | « cloud_print/service/win/chrome_launcher.cc ('k') | cloud_print/service/win/cloud_print_service_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698