Source/core/dom/Attr.h - Issue 1073823002: Correctly handle updates over attached Attrs involving null values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Attr.h

Issue 1073823002: Correctly handle updates over attached Attrs involving null values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Attr.h

diff --git a/Source/core/dom/Attr.h b/Source/core/dom/Attr.h

index 97225bf858b57602fd8423e89d87816235ed73eb..b0794f89c0bf0e916e79eaa9a4a127ed038b5fbc 100644

--- a/Source/core/dom/Attr.h

+++ b/Source/core/dom/Attr.h

@@ -86,7 +86,7 @@ private:

virtual void childrenChanged(const ChildrenChange&) override;

- Attribute& elementAttribute();

+ void updateElementAttribute(const AtomicString&);

// Attr wraps either an element/name, or a name/value pair (when it's a standalone Node.)

// Note that m_name is always set, but m_element/m_standaloneValue may be null.

« no previous file with comments | « LayoutTests/fast/dom/Attr/update-attribute-node-null-value-no-crash-expected.txt ('k') | Source/core/dom/Attr.cpp » ('j') | no next file with comments »