Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Side by Side Diff: Source/core/dom/Attr.h

Issue 1073823002: Correctly handle updates over attached Attrs involving null values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 79
80 virtual String nodeValue() const override { return value(); } 80 virtual String nodeValue() const override { return value(); }
81 virtual void setNodeValue(const String&) override; 81 virtual void setNodeValue(const String&) override;
82 virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) override; 82 virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) override;
83 83
84 virtual bool isAttributeNode() const override { return true; } 84 virtual bool isAttributeNode() const override { return true; }
85 virtual bool childTypeAllowed(NodeType) const override; 85 virtual bool childTypeAllowed(NodeType) const override;
86 86
87 virtual void childrenChanged(const ChildrenChange&) override; 87 virtual void childrenChanged(const ChildrenChange&) override;
88 88
89 Attribute& elementAttribute(); 89 void updateElementAttribute(const AtomicString&);
90 90
91 // Attr wraps either an element/name, or a name/value pair (when it's a stan dalone Node.) 91 // Attr wraps either an element/name, or a name/value pair (when it's a stan dalone Node.)
92 // Note that m_name is always set, but m_element/m_standaloneValue may be nu ll. 92 // Note that m_name is always set, but m_element/m_standaloneValue may be nu ll.
93 RawPtrWillBeMember<Element> m_element; 93 RawPtrWillBeMember<Element> m_element;
94 QualifiedName m_name; 94 QualifiedName m_name;
95 // Holds the value if it is a standalone Node, or the local name of the 95 // Holds the value if it is a standalone Node, or the local name of the
96 // attribute it is attached to on an Element. The latter may (letter case) 96 // attribute it is attached to on an Element. The latter may (letter case)
97 // differ from m_name's local name. As these two modes are non-overlapping, 97 // differ from m_name's local name. As these two modes are non-overlapping,
98 // use a single field. 98 // use a single field.
99 AtomicString m_standaloneValueOrAttachedLocalName; 99 AtomicString m_standaloneValueOrAttachedLocalName;
100 unsigned m_ignoreChildrenChanged; 100 unsigned m_ignoreChildrenChanged;
101 }; 101 };
102 102
103 DEFINE_NODE_TYPE_CASTS(Attr, isAttributeNode()); 103 DEFINE_NODE_TYPE_CASTS(Attr, isAttributeNode());
104 104
105 } // namespace blink 105 } // namespace blink
106 106
107 #endif // Attr_h 107 #endif // Attr_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/Attr/update-attribute-node-null-value-no-crash-expected.txt ('k') | Source/core/dom/Attr.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698