Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1073723002: Revert of X87: Reimplement Maps and Sets in JS (Closed)

Created:
5 years, 8 months ago by Michael Hablich
Modified:
5 years, 8 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of X87: Reimplement Maps and Sets in JS (patchset #1 id:1 of https://codereview.chromium.org/1066373002/) Reason for revert: Reverting as it resulted in a closed waterfall. Original issue's description: > X87: Reimplement Maps and Sets in JS > > port 909500aa1db9789b68e101045a6359a7fcb30e83 (r27605) > > original commit message: > Previously, the only optimized code path for Maps and Sets was for String keys. > This was achieved through an implementation of various complex operations > in Hydrogen. This approach was neither scalable nor forward-compatible. > > This patch adds the necessary intrinsics to implement Maps and Sets almost entirely > in JS. The added intrinsics are: > > %_FixedArrayGet > %_FixedArraySet > %_TheHole > %_JSCollectionGetTable > %_StringGetRawHashField > > With these additions, as well as a few changes to what's exposed as runtime functions, > most of the C++ code backing Maps and Sets is gone (including both runtime code in > objects.cc and Crankshaft in hydrogen.cc). > > BUG= > > Committed: https://crrev.com/56600a35a49ffa5abcba66b14839089de3589ad9 > Cr-Commit-Position: refs/heads/master@{#27681} TBR=weiliang.lin@intel.com,chunyang.dai@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a0486f128109443ed07802fb463c267e53533d81 Cr-Commit-Position: refs/heads/master@{#27682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Hablich
Created Revert of X87: Reimplement Maps and Sets in JS
5 years, 8 months ago (2015-04-09 06:49:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073723002/1
5 years, 8 months ago (2015-04-09 06:49:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 06:49:35 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a0486f128109443ed07802fb463c267e53533d81 Cr-Commit-Position: refs/heads/master@{#27682}
5 years, 8 months ago (2015-04-09 06:49:45 UTC) #4
Michael Hablich
5 years, 8 months ago (2015-04-09 07:10:58 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1077543002/ by hablich@chromium.org.

The reason for reverting is: Revert the revert as this commit cannot be the
cause for the closed tree..

Powered by Google App Engine
This is Rietveld 408576698