Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1073533002: OOPIF: Don't crash when running layout tests that have an OOP iframe. (Closed)

Created:
5 years, 8 months ago by alexmos
Modified:
5 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, site-isolation-reviews_chromium.org, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOPIF: Don't crash when running layout tests that have an OOP iframe. This CLs fixes a few places in layout test code that were assuming that the top-level frame is local, which was causing renderer crashes when running a layout test containing a cross-site frame with --site-per-process. For example, most tests under http/tests/security/postMessage/ ran into this. BUG=474792 TEST=http/tests/security/postMessage/* tests don't crash with --site-per-process Committed: https://crrev.com/297eab63774e6b75d2fccef92c1991707be16246 Cr-Commit-Position: refs/heads/master@{#324311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/shell/renderer/layout_test/webkit_test_runner.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/accessibility_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
alexmos
Charlie, can you please take a look? These bailouts get layout tests to not crash ...
5 years, 8 months ago (2015-04-08 17:45:59 UTC) #2
Charlie Reis
[+jochen to CC for WebKitTestRunner] LGTM as a short term workaround to get layout tests ...
5 years, 8 months ago (2015-04-08 21:46:20 UTC) #3
alexmos
On 2015/04/08 21:46:20, Charlie Reis wrote: > [+jochen to CC for WebKitTestRunner] > > LGTM ...
5 years, 8 months ago (2015-04-08 21:55:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073533002/1
5 years, 8 months ago (2015-04-08 21:56:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 23:58:30 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 23:59:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/297eab63774e6b75d2fccef92c1991707be16246
Cr-Commit-Position: refs/heads/master@{#324311}

Powered by Google App Engine
This is Rietveld 408576698