content/shell/renderer/test_runner/accessibility_controller.cc - Issue 1073533002: OOPIF: Don't crash when running layout tests that have an OOP iframe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/accessibility_controller.cc

Issue 1073533002: OOPIF: Don't crash when running layout tests that have an OOP iframe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/test_runner/accessibility_controller.cc

diff --git a/content/shell/renderer/test_runner/accessibility_controller.cc b/content/shell/renderer/test_runner/accessibility_controller.cc

index 125f071d3f6ffa50f161747e3239f0d6eeeb7819..06531a0ec76c19139c5a8c30d3496c8dde72ebc9 100644

--- a/content/shell/renderer/test_runner/accessibility_controller.cc

+++ b/content/shell/renderer/test_runner/accessibility_controller.cc

@@ -168,7 +168,7 @@ void AccessibilityController::NotificationReceived(

v8::HandleScope handle_scope(isolate);

blink::WebFrame* frame = web_view_->mainFrame();

- if (!frame)

+ if (!frame || frame->isWebRemoteFrame())

return;

v8::Handle<v8::Context> context = frame->mainWorldScriptContext();

« no previous file with comments | « content/shell/renderer/layout_test/webkit_test_runner.cc ('k') | no next file » | no next file with comments »