Issue 1073473003: SkString: remove fStr member

Issue 1073473003: SkString: remove fStr member (Closed)

Created:
5 years, 8 months ago by hal.canary

Modified:
5 years, 8 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

SkString: remove fStr member Motivation: I'd like sizeof(SkString) to be the same in Debug and Release. Committed: https://skia.googlesource.com/skia/+/16e833d5aac6570e134cf8e5356df635e01e092e

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -26 lines)			Patch
	M	include/core/SkString.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/core/SkString.cpp	View		4 chunks	+0 lines, -25 lines	0 comments	Download

Total messages: 9 (3 generated)

hal.canary

I'm not sure what kind of bugs this member is guarding against. Surely we're all ...

5 years, 8 months ago (2015-04-08 16:53:34 UTC) #2

reed1

the field is present to easy querying the contents from within a debug (e.g. gdb) ...

5 years, 8 months ago (2015-04-08 19:48:40 UTC) #5

reed1

That also said, we should, as a rule, not require that sizeof be the same ...

5 years, 8 months ago (2015-04-08 19:49:07 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073473003/1

5 years, 8 months ago (2015-04-08 19:49:21 UTC) #8

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 20:01:26 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/16e833d5aac6570e134cf8e5356df635e01e092e