Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: src/core/SkString.cpp

Issue 1073473003: SkString: remove fStr member (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkString.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkString.cpp
diff --git a/src/core/SkString.cpp b/src/core/SkString.cpp
index b43351599f114c0d7f0b3a1d2e179e3a26b3bca1..c10347dad119ef86a6cd5d718515bd0057a00c01 100644
--- a/src/core/SkString.cpp
+++ b/src/core/SkString.cpp
@@ -247,48 +247,32 @@ void SkString::validate() const {
SkASSERT(fRec->fRefCnt > 0);
SkASSERT(0 == fRec->data()[fRec->fLength]);
}
- SkASSERT(fStr == c_str());
}
#endif
///////////////////////////////////////////////////////////////////////////////
SkString::SkString() : fRec(const_cast<Rec*>(&gEmptyRec)) {
-#ifdef SK_DEBUG
- fStr = fRec->data();
-#endif
}
SkString::SkString(size_t len) {
fRec = AllocRec(NULL, len);
-#ifdef SK_DEBUG
- fStr = fRec->data();
-#endif
}
SkString::SkString(const char text[]) {
size_t len = text ? strlen(text) : 0;
fRec = AllocRec(text, len);
-#ifdef SK_DEBUG
- fStr = fRec->data();
-#endif
}
SkString::SkString(const char text[], size_t len) {
fRec = AllocRec(text, len);
-#ifdef SK_DEBUG
- fStr = fRec->data();
-#endif
}
SkString::SkString(const SkString& src) {
src.validate();
fRec = RefRec(src.fRec);
-#ifdef SK_DEBUG
- fStr = fRec->data();
-#endif
}
SkString::~SkString() {
@@ -346,9 +330,6 @@ void SkString::reset() {
}
fRec = const_cast<Rec*>(&gEmptyRec);
-#ifdef SK_DEBUG
- fStr = fRec->data();
-#endif
}
char* SkString::writable_str() {
@@ -364,9 +345,6 @@ char* SkString::writable_str() {
sk_free(fRec);
}
fRec = rec;
- #ifdef SK_DEBUG
- fStr = fRec->data();
- #endif
}
}
return fRec->data();
@@ -633,9 +611,6 @@ void SkString::swap(SkString& other) {
other.validate();
SkTSwap<Rec*>(fRec, other.fRec);
-#ifdef SK_DEBUG
- SkTSwap<const char*>(fStr, other.fStr);
-#endif
}
///////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « include/core/SkString.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698